Add Deflate64 support to Calamari Deploy implementation of SharpCompress

Hoffmann_Travis · 3 September 2019 16:59

From what I can tell, Octopus 2019.3.4 (version we are on) does not support zip64 for the package deploy step of zip files. I did find this:

But I think that’s your old zip library prior to SharpCompress (?).

This also seems to indicated the library supports it:

github.com

adamhathcock/sharpcompress/blob/master/FORMATS.md

# Formats

## Accessing Archives

* Archive classes allow random access to a seekable stream.
* Reader classes allow forward-only reading on a stream.
* Writer classes allow forward-only Writing on a stream.

## Supported Format Table

| Archive Format         | Compression Format(s)                             | Compress/Decompress | Archive API     | Reader API | Writer API    |
| ---------------------- | ------------------------------------------------- | ------------------- | --------------- | ---------- | ------------- |
| Rar                    | Rar                                               | Decompress (1)      | RarArchive      | RarReader  | N/A           |
| Zip (2)                | None, DEFLATE, Deflate64, BZip2, LZMA/LZMA2, PPMd | Both                | ZipArchive      | ZipReader  | ZipWriter     |
| Tar                    | None                                              | Both                | TarArchive      | TarReader  | TarWriter (3) |
| Tar.GZip               | DEFLATE                                           | Both                | TarArchive      | TarReader  | TarWriter (3) |
| Tar.BZip2              | BZip2                                             | Both                | TarArchive      | TarReader  | TarWriter (3) |
| Tar.LZip               | LZMA                                              | Both                | TarArchive      | TarReader  | TarWriter (3) |
| Tar.XZ                 | LZMA2                                             | Decompress          | TarArchive      | TarReader  | TarWriter (3) |
| GZip (single file)     | DEFLATE                                           | Both                | GZipArchive     | GZipReader | GZipWriter    |

This file has been truncated. show original

Stack Trace:
System.NotSupportedException: CompressionMethod: Deflate64
September 3rd 2019 09:23:56Error
at SharpCompress.Common.Zip.ZipFilePart.CreateDecompressionStream(Stream stream)
September 3rd 2019 09:23:56Error
at SharpCompress.Common.Zip.ZipFilePart.GetCompressedStream()
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteTo(IArchiveEntry archiveEntry, Stream streamToWriteTo)
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteToFile(IArchiveEntry entry, String destinationFileName, ExtractionOptions options)
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteToDirectory(IArchiveEntry entry, String destinationDirectory, ExtractionOptions options)
September 3rd 2019 09:23:56Error
at Calamari.Integration.Packages.ZipPackageExtractor.Extract(String packageFile, String directory, Boolean suppressNestedScriptWarning)
September 3rd 2019 09:23:56Error
at Calamari.Deployment.Conventions.ExtractPackageConvention.Install(RunningDeployment deployment)
September 3rd 2019 09:23:56Error
at Calamari.Deployment.ConventionProcessor.RunInstallConventions()
September 3rd 2019 09:23:56Error
at Calamari.Deployment.ConventionProcessor.RunConventions()
September 3rd 2019 09:23:56Error
Running rollback conventions…
September 3rd 2019 09:23:56Error
CompressionMethod: Deflate64
September 3rd 2019 09:23:56Error
System.NotSupportedException
September 3rd 2019 09:23:56Error
at SharpCompress.Common.Zip.ZipFilePart.CreateDecompressionStream(Stream stream)
September 3rd 2019 09:23:56Error
at SharpCompress.Common.Zip.ZipFilePart.GetCompressedStream()
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteTo(IArchiveEntry archiveEntry, Stream streamToWriteTo)
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteToFile(IArchiveEntry entry, String destinationFileName, ExtractionOptions options)
September 3rd 2019 09:23:56Error
at SharpCompress.Archives.IArchiveEntryExtensions.WriteToDirectory(IArchiveEntry entry, String destinationDirectory, ExtractionOptions options)
September 3rd 2019 09:23:56Error
at Calamari.Integration.Packages.ZipPackageExtractor.Extract(String packageFile, String directory, Boolean suppressNestedScriptWarning)
September 3rd 2019 09:23:56Error
at Calamari.Deployment.Conventions.ExtractPackageConvention.Install(RunningDeployment deployment)
September 3rd 2019 09:23:56Error
at Calamari.Deployment.ConventionProcessor.RunInstallConventions()
September 3rd 2019 09:23:56Error
at Calamari.Deployment.ConventionProcessor.RunConventions()
September 3rd 2019 09:23:56Error
at Calamari.Commands.DeployPackageCommand.Execute(String[] commandLineArguments)
September 3rd 2019 09:23:56Error
at Calamari.Program.Execute(String[] args)

This is not a big priority for us as the admin used deflate64 by mistake and deflate is more or less just fine for our needs, but I thought I would report it.

Kenneth_Bates · 4 September 2019 02:02

Hi Travis,

Thanks for getting in touch! I appreciate you reporting this, and I’ve passed this information on to the engineers. Glad to hear it’s not impacting you too much though.

Best regards,

Kenny

system · 4 October 2019 02:02

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.