(Nested) Zip files are not supported in NuGet packages (includes fix)

Deploying a nuget package that contains a zip file results in an “System.NotSupportedException: Unknown header: …” error. See screenshot attached.

It seems that when using the ZipReader from the SharpCompress library it doesn’t always work with nested zip files. A workarround to this seems to be to use the ZipArchive class instead tof the ZipReader.

There is a similar fix like this for the following issue: https://github.com/OctopusDeploy/Issues/issues/2888

I’ve proposed a fix in the following pull request: https://github.com/OctopusDeploy/Calamari/pull/195

Thanks in advance!

Dennis van den Berg
Vesting Finance

Hi Dennis,

Thanks for the PR! It looks good to me but I can’t merge it until the CLA is signed.

Cheers,
Shane

Hi Shane,

Didn’t knew a CLA had to be signed. I’ve signed the CLA.

Met vriendelijke groet, With kind regards,

Dennis van den Berg
Software Developer

[cid:image001.jpg@01D214B4.1917BAA0]

Bonairelaan 4, 1213 VH Hilversum
Postbus 1080, 1200 BB Hilversum
d.vandenberg@vestingfinance.nlmailto:d.vandenberg@vestingfinance.nl
T

035-7999226

www.vestingfinance.nlhttp://www.vestingfinance.nl/
voor een financieel vitale maatschappij

Vesting Finance Holding B.V. gevestigd te Hilversum; Handelsregister: 32115453. De informatie opgenomen in dit bericht kan vertrouwelijk zijn en is uitsluitend bestemd voor de geadresseerde. Indien u dit bericht onterecht ontvangt, wordt u verzocht de inhoud niet te gebruiken en de afzender direct te informeren.

Vesting Finance Holding B.V. has its seat at Hilversum; Commercial Registration number: 32115453. The information contained in this message may be confidential, and is intended to be exclusively for the addressee. Should you receive this message unintentionally, please do not use the contents herein and notify the sender immediately by return e-mail.

Van: Shane Gill [mailto:tender2+dcbdc2bc3e@tenderapp.com]
Verzonden: vrijdag 2 juni 2017 02:08
Aan: Dennis van den Berg | Vesting Finance d.vandenberg@vestingfinance.nl
Onderwerp: Re: (Nested) Zip files are not supported in NuGet packages (includes fix) [Problems #54892]

image001.jpg

Thank you!