JSON Configuration Variables not working on some variables

oliverrc · 29 May 2019 12:14

As stated it seems some variables are not being replaced by the “JSON Configuration Variables” feature.

Our appsettings.json looks as follows:

{
  "ApplicationInsights": {
    "InstrumentationKey": "..."
  },
  "Octopus": {
    "ServerAddress": "...",
    "ApiKey": "API-..."
  }
}

In Octopus Server we have set the variables as follows

ApplicationInsights:InstrumentationKey
Octopus:ServerAddress
Octopus:ApiKey

The ApplicationInsights.InstrumentationKey replacement works fine but neither of the Octopus.*
variables are replaced. They remain unchanged after the deployment.

The log clearly shows that the replacement has found and worked on the appsettings.json

11:58:46 Info | Performing JSON variable replacement on 'C:\Octopus\Applications\Dev\MyApp\1.0.0.20_3\appsettings.json'

I had a look at the “JsonConfigurationVariableReplacer” and could see no indication of “Octopus” as a reserved word.

github.com

OctopusDeploy/Calamari/blob/master/source/Calamari.Shared/Integration/JsonVariables/JsonConfigurationVariableReplacer.cs

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using Octostache;

namespace Calamari.Integration.JsonVariables
{
    public class JsonConfigurationVariableReplacer : IJsonConfigurationVariableReplacer
    {
        public void ModifyJsonFile(string jsonFilePath, VariableDictionary variables)
        {
            var root = LoadJson(jsonFilePath);

            var map = new JsonUpdateMap();
            map.Load(root);
            map.Update(variables);

This file has been truncated. show original

I’m scratching my head why this isn’t working.

Alex.Rolley · 30 May 2019 05:58

Hi @oliverrc,

Thanks for getting in touch, and sorry for the confusion on this one!

You’re theory that Octopus was a reserved word is correct, it was just hiding down on line 185. If you remove Octopus from the variable names you should be good to go.

Please let me know if there is anything else I can help with.

Regards,
Alex

oliverrc · 30 May 2019 06:13

Ah damn, right there plain as daylight. Sorry about that, completely missed it. Appreciate the feedback, will try find a different name.

system · 30 June 2019 00:03

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.